enhancement(ruleset): add support for category-level ruleset expansion with docker/all syntax #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n with docker/all syntax Add support for `docker/all` syntax to automatically expand to all bundles in a category, eliminating the need to manually specify each bundle. Changes: - Add ManifestProvider interface for dependency injection and testing - Update ParseSpec() to detect "all" keyword and mark for expansion - Add GetAllBundleNames() helper to Manifest for bundle listing - Extract expandBundleSpecs() function with interface-based design - Add 11 comprehensive mock-based unit tests with 100% code coverage - Support mixed usage: --ruleset docker/all --ruleset python/django Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 80.24% 80.25% +0.01%
==========================================
Files 99 99
Lines 10953 10992 +39
==========================================
+ Hits 8789 8822 +33
- Misses 1813 1819 +6
Partials 351 351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why This Change?
Users currently must manually specify each bundle individually when they want to run all rules for a technology:
This is tedious and error-prone. Users want a simple way to run ALL rules for a category with a single flag.
Summary of Changes
New Feature: Support
category/allsyntax (e.g.,docker/all,python/all) to automatically expand to all bundles in that category.Implementation:
ManifestProviderinterface for testability and dependency injectionParseSpec()to detect "all" keyword → converts to internal marker "*"GetAllBundleNames()helper to Manifest for retrieving all bundle namesexpandBundleSpecs()function with interface-based design for easy testingUsage Examples:
Testing:
Files Changed: 7 files, +353 lines